Skip to content

Update routing.rst #12646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Update routing.rst #12646

merged 1 commit into from
Nov 23, 2019

Conversation

amine-betari
Copy link
Contributor

We suppose we have thie URL :
http://127.0.0.1:8000/share/symfony//ezplatform/php/drupal/wordpess

path => symfony/ezplatform/php/drupal
token => wordpess

@amine-betari
Copy link
Contributor Author

@javiereguiluz did you test it ?

@wouterj
Copy link
Member

wouterj commented Nov 23, 2019

Indeed, $token will not be empty (unless marked as optional). We should maybe tell that the last one only get the last path and the rest of the match is matched by the first argument. Are you willing to change this note?

@amine-betari
Copy link
Contributor Author

@wouterj

Done

wouterj added a commit that referenced this pull request Nov 23, 2019
This PR was squashed before being merged into the 4.4 branch (closes #12646).

Discussion
----------

Update routing.rst

We suppose we have thie URL :
http://127.0.0.1:8000/share/symfony//ezplatform/php/drupal/wordpess

**path** => symfony/ezplatform/php/drupal
**token** => wordpess

Commits
-------

853a7b2 Update routing.rst
wouterj added a commit that referenced this pull request Nov 23, 2019
@wouterj wouterj merged commit 853a7b2 into symfony:4.4 Nov 23, 2019
wouterj added a commit that referenced this pull request Nov 23, 2019
* 4.4:
  [#12646] Minor sentence and standard fix
  Update routing.rst
@wouterj
Copy link
Member

wouterj commented Nov 23, 2019

Hi! Thanks for your quick responses! I've now merged it and did some minor fixes in 35ed391 afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants